dblaikie added a comment.

Might be worth rewording the commit, or  splitting it - I'd say the 
introduction of `optdebug` should be the noteworthier part of this patch (or 
whichever patch introduces it) - so either "this patch adds optdebug, and a 
first/exemplar use of it in postra scheduler" or split it into a patch that 
just adds the attribute and no uses, and one that adds the use. (I'd lean 
towards splitting it up, personally & I guess maybe moving to github pull 
requests in the process, perhaps)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157615/new/

https://reviews.llvm.org/D157615

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to