zequanwu added a comment.

I feel like either this feature not working well with mac or we should keep 
`__llvm_prf_names` section in the binary.

Current idea is to completely get rid of `__llvm_prf_names` section in the 
binary. Even if I fixed the issue https://reviews.llvm.org/D157913#4648296, 
llvm-cov will need to read information from 3 different places on mac: the 
binary (for `__llvm_cov_fun` and `__llvm_cov_map`), debug info (unused function 
names, which could live in `__llvm_prf_names`) and indexed profile file for 
(counter, data, instrumented function names). If we keep `__llvm_prf_names` in 
the binary, then llvm-cov doesn't need to look into debug info again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157913/new/

https://reviews.llvm.org/D157913

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to