cor3ntin added a comment.

I had a chat with @hubert.reinterpretcast and @tahonermann.
We reached consensus on wanting to make sure the codepoint value is formatted 
in a future-proof way so that if we ever implement escaping of lone combining 
codepoint, this case would be handled as well.

To do that, we can:

- * Expose the escaping mechanism) (done by `pushEscapedString` in 
Diagnostic.cpp) as a new `EscapeStringForDiagnostic` function. Use that to 
escape the code point (line 16921)

I think that should be the last change we need here. Thanks for being patient 
with us!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155610/new/

https://reviews.llvm.org/D155610

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to