courbet added a comment. In D153131#4651198 <https://reviews.llvm.org/D153131#4651198>, @courbet wrote:
> In D153131#4651074 <https://reviews.llvm.org/D153131#4651074>, @aaronpuchert > wrote: > >> Looks still good to me. As I wrote on D153132 >> <https://reviews.llvm.org/D153132>, I don't think we need it anymore, but if >> you disagree I think I can accept it as well. > > Sorry, I misunderstood the last comment as an endorsement of the change. I've > reverted the base commit and I'll rebase this on main without the changes. After trying a rebase I think the code is better with the base change. See my comments in https://reviews.llvm.org/D153132. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153131/new/ https://reviews.llvm.org/D153131 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
