================
@@ -0,0 +1,222 @@
+//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM 
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// This file defines the StringRefOrHashCode class. It is to represent function
+// names in a sample profile, which can be in one of two forms - either a
+// regular string, or a 64-bit hash code.
----------------
MatzeB wrote:

- Should use `/// @file` for documentation about a file so doxygen can pick it 
up.
- This comment seems wrong ("StringRegOrHashCode" was renamed I guess?). It 
also seems to mainly repeat what the one class in here is about.

I would suggest to simply remove the file comment (and instead make sure the 
comment on the class is good).

https://github.com/llvm/llvm-project/pull/66164
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to