nemanjai added a comment.

In https://reviews.llvm.org/D24397#555470, @spatel wrote:

> Having a clang regression/unit test that depends on optimizer behavior is 
> generally viewed as wrong. Can the tests be split into front-end (clang) 
> tests and separate tests for the IR optimizer? Both x86 and AArch64 have done 
> something like that in the last few months for testing of builtins/intrinsics.


Yeah, that sounds reasonable. I'll remove the -O2 from the test case and remove 
the checks for the select instructions. That's really the only major 
difference. So am I to understand the nsw/nuw flags will not be added without 
-O2 and the aforementioned changes will suffice?


Repository:
  rL LLVM

https://reviews.llvm.org/D24397



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to