ChuanqiXu9 wrote: > Is the issue with MDC's FileDeps that we are calling > `makeAbsoluteAndPreferred` on the paths? Maybe we could instead move that > call into `FullDependencyConsumer`. Or are there other issues? > > The fact we need to add additional `MDC.IsStdModuleP1689Format` checks in > this PR to prevent the normal consumer callbacks is not great. This makes MDC > aware of implementation details of the specific output format.
Yes, the issue can be solved by not calling `makeAbsoluteAndPreferred` too. And it sounds indeed a good idea to move it to FullDependencyConsumer. Will do. https://github.com/llvm/llvm-project/pull/69551 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
