elsteveogrande accepted this revision.
elsteveogrande added a reviewer: elsteveogrande.
elsteveogrande added a comment.
This revision is now accepted and ready to land.

Thought I'd take a look at the list of diffs and take a stab at a few (a few 
easy-looking and short ones :) ) to unblock some ppl, and unless @djasper has 
strong opinions about it I'd say why not.

Looking at other rules "nearby" I see spaces inside and outside square-brackets 
and angle-brackets, so it makes sense to allow this for conditions, especially 
if someone thinks this helps make it more readable, and for `not` as well (I 
personally like that one, it's easy to eyeball right past that `!`.

Also it appears to be off by default and I assume the unit tests work :)


https://reviews.llvm.org/D25171



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to