ABataev added inline comments.
================ Comment at: clang/lib/Parse/ParseOpenMP.cpp:3328-3332 if (!FirstClause) { Diag(Tok, diag::err_omp_more_one_clause) << getOpenMPDirectiveName(DKind) << getOpenMPClauseName(CKind) << 0; ErrorFound = true; } ---------------- If there is a second instance of this clause, it should be reported here ================ Comment at: clang/lib/Parse/ParseOpenMP.cpp:3830 + // Store fail parameter for Sema. + FailClause->initFailClause(LParenLoc, CKind, MemOrderLoc); + ---------------- That's a bad place, it should be done in Sema. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits