MaskRay marked an inline comment as done. MaskRay added inline comments.
================ Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4435-4448 struct CallEndCatch final : EHScopeStack::Cleanup { CallEndCatch(bool MightThrow) : MightThrow(MightThrow) {} bool MightThrow; void Emit(CodeGenFunction &CGF, Flags flags) override { if (!MightThrow) { CGF.EmitNounwindRuntimeCall(getEndCatchFn(CGF.CGM)); ---------------- ChuanqiXu wrote: > If `__cxa_end_catch ` is nounwind always now, do we need to refactor this > one? Like: > ``` > struct CallEndCatch final : EHScopeStack::Cleanup { > CallEndCatch() {} > > void Emit(CodeGenFunction &CGF, Flags flags) override { > CGF.EmitNounwindRuntimeCall(getEndCatchFn(CGF.CGM)); > } > }; > ``` Since `__cxa_end_catch` is no longer `nounwind` in the latest revision, we cannot simplify the code... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108905/new/ https://reviews.llvm.org/D108905 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits