rnk added a comment.

Nice, probably ready to land with one revision.



> majnemer wrote in CGBuiltin.cpp:2640-2647
> This should be in an anonymous namespace. Also, consider using an `enum 
> class` instead of an `enum` nested inside a namespace.

Let's also use a more specific name than MSVC, maybe MSVCIntrin or something.

https://reviews.llvm.org/D25264



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to