jaredgrubb added a comment. In D150083#4656832 <https://reviews.llvm.org/D150083#4656832>, @owenpan wrote:
> Thank you for your patience! I appreciate the help :) I'm excited to get this in! > In D150083#4655528 <https://reviews.llvm.org/D150083#4655528>, @owenpan wrote: > >> See also D153228 <https://reviews.llvm.org/D153228>. > > Would this patch have a similar performance issue? Reading through the issue, I don't think so. As I understand that issue, the scale-problem is due to how the passes interact with one another as a whole (since that setting creates a Pass for _each_ qualifier). This ObjC pass uses only ONE pass to handle the ordering of all property attributes. I intentionally did not copy that part of the Qualifier pass because it didn't seem to actually help my use-case, which is much narrower (primarily that I only have to operate on lines that look like properties, not in arbitrary places like function args and variable declarations, etc.). Please correct me if I missed something about that patch that could apply. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
