ahatanak accepted this revision. ahatanak added a comment. LGTM with a few nits.
Please fix lib/Headers/intrin.h too and commit it as a separate patch. ================ Comment at: lib/Sema/SemaStmtAsm.cpp:142 +// Extracting the register name from the Expression value, +// if there is no register name to extract, returns "" +StringRef ExtractRegisterName(const Expr *Expression, ---------------- This should be a static function that starts with a lower case letter. ================ Comment at: lib/Sema/SemaStmtAsm.cpp:160 +// clobbers list. If there's a conflict, returns the location of the +// conflicted clobber, else returns nullptr +SourceLocation ---------------- This should be a static function that starts with a lower case letter. https://reviews.llvm.org/D15075 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
