On 12 October 2016 at 08:59, Haojian Wu via cfe-commits
<cfe-commits@lists.llvm.org> wrote:
> Author: hokein
> Date: Wed Oct 12 02:59:54 2016
> New Revision: 283981
> URL: http://llvm.org/viewvc/llvm-project?rev=283981&view=rev
> Log:
> [ClangTidy] Add UsingInserter and NamespaceAliaser

Hi Haojian,

Many, if not all buildbots building Clang *also* build
clang-tools-extra. Any commit you make to your projects are bound to
affect many more buildbots than you would expect. So I'm asking you to
be careful with your commits, as this is not the first time.

One rule of thumb that I took it to heart very early on, after making
the same mistakes myself, is to *always* build and test someone else's
patch on my machine, in a configuration that is likely to be present
in most buildbots.

That practically means the following:

1. Have a check-out with LLVM+Clang+RT
2. Update it to the latest trunk, apply the patch
2.1 If it doesn't apply cleanly, refuse the patch, ask to rebase (you
could rebase it wrong and not notice, I've done that)
2.2 The original author rebases and updates the review
2.3 Goto 2
3. Run "make check-all" and it has to pass.
4. Commit, and hope for the best.

If even after that, it broke some obscure buildbot, that's life, we
can deal with that.

cfe-commits mailing list

Reply via email to