alexshap added inline comments.
Comment at: lib/Analysis/LiveVariables.cpp:66
- const CFGBlock *b = worklist.pop_back_val();
+ const auto I = --worklist.end();
+ const CFGBlock *b = *I;
> zaks.anna wrote:
> > '--wroklist.end()' -> 'worklist.rbegin()'?
> 1. rbegin - OK - will update the diff
> 2. regarding http://llvm.org/docs/doxygen/html/classllvm_1_1SparseSet.html
> (i took a look at it before) - the problem is that i don't see any containers
> which take a custom comparator & provide "ordered set"-like functionality
> 3. regarding the performance - i can run static analyzer against LLVM and
> measure the time (compare the old version with this one). Will post the
> results here.
4. Will test the approach suggested by @NoQ as well.
cfe-commits mailing list