rjmccall added inline comments.

Comment at: lib/CodeGen/CGExpr.cpp:1650
+    }
     switch (Lifetime) {
I think you can fold this a bit more. :)  You have exactly the same switch 
statement below, and several of the cases are identical; for the others, you 
can just sink the isInit check into the case.

Note that calling EmitStoreOfScalar and returning has the same behavior as 
"falling into the normal path".  isObjCWeak() / isObjCStrong() are checking for 
the GC qualifiers, which are exclusive with ARC lifetime.


cfe-commits mailing list

Reply via email to