Should be fixed in r284391. On Mon, Oct 17, 2016 at 4:59 PM, Haojian Wu <hok...@google.com> wrote:
> Hello Tim, > > Sorry for the trouble and delay (I missed this email previously). > > I'm looking into it. Could you give me a link to the problematic buildbot? > > On Mon, Oct 17, 2016 at 3:44 PM, Tim Northover <t.p.northo...@gmail.com> > wrote: > >> On 14 October 2016 at 13:33, Tim Northover <t.p.northo...@gmail.com> >> wrote: >> > On 14 October 2016 at 06:01, Haojian Wu via cfe-commits >> > <cfe-commits@lists.llvm.org> wrote: >> >> + std::string GuardName(FileName); >> >> + if (IsHeader) { >> >> + std::replace(GuardName.begin(), GuardName.end(), '/', '_'); >> >> + std::replace(GuardName.begin(), GuardName.end(), '.', '_'); >> >> + std::replace(GuardName.begin(), GuardName.end(), '-', '_'); >> > >> > I think this is causing problems with one of our bots that has an '@' >> > in a path it uses. In general it seems like a whitelist based on what >> > a C token is would be better than a blacklist of characters. >> > >> > Could you take a look? >> >> Ping. >> >> Tim. >> > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits