aaron.ballman added inline comments.

Comment at: include/clang/AST/TypeLoc.h:513
 struct BuiltinLocInfo {
-  SourceLocation BuiltinLoc;
+  SourceRange BuiltinRange;
Since this doubles the size of the type loc for builtin types, do you happen to 
have any data on what practical impact this has on RAM usage, say for 
bootstrapping LLVM (or compiling any large source base, really)? Hopefully it's 
not a lot, but it would be nice to know if it's a .1%, 1%, 10%, etc increase in 
usage (or does the change get lost in the noise).

Comment at: unittests/AST/SourceLocationTest.cpp:228
 TEST(CXXConstructorDecl, NoRetFunTypeLocRange) {
Can you also add a test that the range is correct for something like `long 
double`  and `long double _Complex`?


cfe-commits mailing list

Reply via email to