================
@@ -0,0 +1,23 @@
+! Test that -mframe-pointer can accept only specific values.
----------------
banach-space wrote:

You seem to be testing a bit more in this file than this comment suggests (e.g. 
that `-mframe-pointer` will make the compiler insert the new attributes)

Please, could you:
* update the comment to capture what's actually being tested (the 
`-mframe-pointer` flag)
* rename the file - it's testing a particular flag rather than any "func"tion 
"attr"ibute

https://github.com/llvm/llvm-project/pull/74598
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to