bruno added a comment. Thanks for looking into this. It's a nice FixIt to have.
I don't see any dep cycle; clangFormat depends on clangToolingCore, which also depends clangRewrite, which means there are going to be 3 new dependencies for libSema in the end: clangToolingCore, clangRewrite and clangFormat. I don't know the history behind the desired dependencies, I'll let others comment whether this is OK, but my guess it that it depends on the tradeoff, it's hard to justify 3 new deps for a change that is supposed to be simple. How hard is to implement this without using libFormat? ================ Comment at: lib/Sema/SemaLookup.cpp:39 #include "clang/Sema/TypoCorrection.h" +#include "clang/Tooling/Core/Replacement.h" #include "llvm/ADT/STLExtras.h" ---------------- You also want clangToolingCore to be listed as a explicit dep since you're including from it. https://reviews.llvm.org/D25311 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
