bkramer added inline comments.
================ Comment at: lib/Driver/ToolChains.cpp:1438 + if (GCCToolchainDir == "" || GCCToolchainDir == D.SysRoot + "/usr") { + for (const StringRef& CandidateTriple : CandidateTripleAliases) { + llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> File = ---------------- drop the const&. Using StringRef by value is fine. ================ Comment at: lib/Driver/ToolChains.cpp:1445 + File.get()->getBuffer().split(Lines, "\n"); + for (const StringRef& Line : Lines) { + // CURRENT=triple-version ---------------- drop ref ================ Comment at: lib/Driver/ToolChains.cpp:1447 + // CURRENT=triple-version + if (Line.startswith("CURRENT=")) { + const std::pair<StringRef, StringRef> ActiveVersion = ---------------- We have StringRef::consume_front now to make this more convenient. https://reviews.llvm.org/D25661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits