Endilll wrote:

> I have reviewed the tests for libclang and it appears that there are already 
> tests for the rewriter, which are more extensive than the ones I wrote. 
> Therefore, I have decided to mirror the tests from libclang in the Python 
> binding. Please let me know if this approach is appropriate.

If you think that existing tests fully cover yours, then it's appropriate. 
Otherwise, we'd benefit from additional test coverage, but it's not necessarily 
in the scope of this PR.

https://github.com/llvm/llvm-project/pull/77269
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to