arphaman added a comment.
In https://reviews.llvm.org/D13419#581356, @loladiro wrote:
> Hmm, the rebased version of this introduces new errors in
> `test/Modules/cxx-templates.cpp`. That test didn't exist when I wrote this
> code and I'm not familiar with templates. @rsmith could you take a look,
> error is:
>
> error: 'error' diagnostics seen but not expected:
> File /data/keno/llvm/tools/clang/test/Modules/cxx-templates.cpp Line 202:
> definition of 'nested_cls_t' must be imported from module
> 'cxx_templates_common.unimported' before it is required
> File /data/keno/llvm/tools/clang/test/Modules/cxx-templates.cpp Line 202:
> definition of 'nested_cls_t' must be imported from module
> 'cxx_templates_common.unimported' before it is required
>
FWIW, I also found this issue while working on my patch and decided to add
`expected-error 1+{{definition of}}` verified check to that line (
https://reviews.llvm.org/differential/changeset/?ref=558280&whitespace=ignore-most).
It seems that the preceding lines have this check as well, so I assumed that
this diagnostic was expected and my patch fixed a bug that prevented this
diagnostic from showing up.
Repository:
rL LLVM
https://reviews.llvm.org/D13419
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
