https://github.com/vgvassilev commented:

This patch does too many things for me to be able to review it. This patch 
fails on our infrastructure.

I'd propose to simplify it to basically D41416 + the on-disk hash table. We 
should read all of the entries upon module loading to simplify the logic in 
reading the hashes lazily. Reading the hashes lazily could be done but I doubt 
its worth the complexity of the implementation at that stage.

https://github.com/llvm/llvm-project/pull/76774
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to