https://github.com/rjmccall requested changes to this pull request.
> @rjmccall Are these tests adequate? No. You need to test the behavior of ivar accesses in the subclass when there is an intermediate superclass that has ivars declared in all the ways I identified. Your test has many tests for ivar accesses in immediate subclasses of `NSObject`, which is an optimization that we've already been doing for several years. It only tests indirect subclasses in one configuration, which is when the intermediate superclass has all its ivars declared in the `@interface`. https://github.com/llvm/llvm-project/pull/81335 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
