djasper added a comment. In case you still want to move forward with this, some more comments.
Why have you opted for doing this in getNewLineColumn instead of the UnwrappedLineFormatter::formatFirstToken() function I suggested? I think the latter would be way easier, but there might be cases I am not thinking of right now. ================ Comment at: docs/ClangFormatStyleOptions.rst:260 + * ``BS_Whitesmiths`` (in configuration: ``Whitesmiths``) + Like ``Allman``, with the braces intended too. * ``BS_GNU`` (in configuration: ``GNU``) ---------------- indented? ================ Comment at: lib/Format/ContinuationIndenter.h:270 + bool BlockNoExtraIndent; + bool operator<(const ParenState &Other) const { ---------------- No. I don't think it is necessary to add an extra value to the indent state for this and doing so would be costly in runtime. https://reviews.llvm.org/D6833 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits