danalbert added a comment.

> It is defines with a value of 0. This allows you to actually do something 
> better, IMO.

Can we stick with undefined? That's historically how things have been, and I'm 
sure there's code out there depending on that (I had actually written a test 
that would depend on this a few weeks ago).

If we do want to do this, we're going to have to redo the legacy headers as 
they current define this unconditionally (`-Wmacro-redefined`). I suppose we 
probably don't have to worry about people using a new clang with an old NDK, so 
we could just change that, but I don't really see an argument for setting it to 
zero.


https://reviews.llvm.org/D26385



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to