collinfunk wrote:

> Thank you for this PR. This change should have some tests to verify the 
> behavior is correct. I am a little surprised that this does not change any 
> existing tests but maybe we don't have good test coverage.

Hi, thanks for the review. Sorry for the lack of tests. I'm not super familiar 
with LLVM's code and didn't know how to add them. In any case, I believe that 
this issue was fixed in the following pull requests along with better 
Diagnostic groups:

https://github.com/llvm/llvm-project/pull/81658

Can you double check and make sure I am not mistaken? Thanks.


https://github.com/llvm/llvm-project/pull/80244
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to