zaks.anna added a comment.
> Added a python script to merge gcov files.
When the patches that are being reviewed are growing new functionality, it's
much more difficult to review them. Please, submit the python script as a
separate patch.
================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262
+
+static void dumpCoverageInfo(llvm::SmallVectorImpl<char> &Path,
+ SourceManager &SM) {
----------------
xazax.hun wrote:
> zaks.anna wrote:
> > Can this be a debug checker?
> You mean the dumping part or also collecting the coverage? It can be a debug
> checker if we add a new callback like "checkBasicBlockBegin". I did not want
> to add such callback just for a debug check. However, it is possible to move
> only the dumping part to a separate checker. What would you prefer?
I would prefer to add a "checkBasicBlockBegin" callback and move all of this
diagnostic code into a debug checker.
================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:277
+ if (!OutFile) {
+ llvm::errs() << FilePath << " Fuck!\n";
+ continue;
----------------
zaks.anna wrote:
> Please, come up with constructive error messages.
How was this addressed?
https://reviews.llvm.org/D25985
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
