malcolm.parsons added inline comments.

================
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
         "modernize-use-bool-literals");
-    CheckFactories.registerCheck<UseDefaultCheck>("modernize-use-default");
+    
CheckFactories.registerCheck<UseEqualsDefaultCheck>("modernize-use-equals-default");
     CheckFactories.registerCheck<UseEmplaceCheck>("modernize-use-emplace");
----------------
aaron.ballman wrote:
> What do we want to do, if anything, for people who have scripts using the old 
> name? Do we want to keep the old name as an alias to the new name for some 
> period of time?
An alias helps if the check was enabled by name, but not if it was disabled by 
name.
If the alias is temporary, would you want a deprecation warning?
I wouldn't want to warn about `-checks=modernize*`, but maybe warning for 
`-checks=modernize-use-default` would be useful.


https://reviews.llvm.org/D26511



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to