mgorny added inline comments.

================
Comment at: test/lit.cfg:109
+    if not llvm_shlib_dir:
+        lit_config.fatal('No LLVM shlib dir set!')
     llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
----------------
beanz wrote:
> Should this really be fatal? It seems to me in many cases you might not need 
> this to be set.
I don't mind either way. I left it like this since I really don't see a case 
when it could be unset ;-).


https://reviews.llvm.org/D26115



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to