================ @@ -3666,11 +3673,14 @@ void FunctionProtoType::Profile(llvm::FoldingSetNodeID &ID, QualType Result, // Finally we have a trailing return type flag (bool) // combined with AArch64 SME Attributes, to save space: // int + // Then add the FunctionEffects // // There is no ambiguity between the consumed arguments and an empty EH // spec because of the leading 'bool' which unambiguously indicates // whether the following bool is the EH spec or part of the arguments. + ID.AddPointer(epi.FunctionEffects.getOpaqueValue()); // TODO: Where??? ---------------- Sirraide wrote:
Yeah, you’re putting the effects first, which seems fine so long as you always add the effects (you’re right in that there seem to be some optional fields, so I’d be wary about moving it further down); updating the comment to reflect where the effects are encoded is a good idea—I didn’t notice that at first because the diff didn’t include that part of the comment. https://github.com/llvm/llvm-project/pull/84983 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
