hokein added inline comments.
================ Comment at: change-namespace/ChangeNamespace.cpp:343 + // FIXME(ioeric): this will change a base-class constructor initializer from + // "Base::Base(...)" to "ns::Base()", which compiles but is not perfect. Finder->addMatcher(nestedNameSpecifierLoc( ---------------- Maybe we can filter it out in `run(MatcherResult)` function rather than in AST matcher? If we meet a specifier like `Base::Base()` in `CXXCtorInitializer`, we just skip them. https://reviews.llvm.org/D26637 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits