https://github.com/NagyDonat commented:
Seems reasonable at first glance. However, I feel an urge to bikeshed that the "[invisible]" prefix is a bit puzzling for the developer who encounters it. Consider replacing it with the prefix "[debug]" which is a more conventional signal for "this is a debug printout" (i.e. normal users won't see it). Another alternative could be adding the name of the command-line flag either before or after the printout to explain and highlight its origin (similarly to the way how the checker name is printed). By the way what's the reason for implementing this as a command-line flag instead of a checker in the `debug` group? (I'd presume that a debug checker would involve more boilerplate.) https://github.com/llvm/llvm-project/pull/84823 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
