================
@@ -2100,8 +2100,12 @@ void X86_64ABIInfo::classify(QualType Ty, uint64_t 
OffsetBase, Class &Lo,
         postMerge(Size, Lo, Hi);
         return;
       }
+
+      bool InMemory = Offset % getContext().getTypeAlign(i->getType()) ||
+                      (i->getType()->getAs<BuiltinType>() &&
----------------
efriedma-quic wrote:

I don't like the use of BuiltinType here; I don't think it really captures the 
relevant cases.  Do we want to handle pointers? vectors? arrays?

Maybe just `bool InMemory = Offset % 
getContext().getTypeAlign(i->getType()->getCanonicalType())` is sufficient to 
handle this case without trying to reason about individual types.

https://github.com/llvm/llvm-project/pull/86902
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to