[PATCH] D27029: [libc++] [test] Unbreak variant::swap test for non-libc++ libraries

[Casey Carter via cfe-commits]

CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.

`LIBCPP_ONLY(foo;)` at namespace scope is bad, and it should feel bad.


https://reviews.llvm.org/D27029

Files:
  test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp


Index: test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp
===================================================================
--- test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp
+++ test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp
@@ -577,10 +577,10 @@
   }
 }
 
-
+#ifdef _LIBCPP_VERSION
 // This is why variant should SFINAE member swap. :-)
-LIBCPP_ONLY(template class std::variant<int, NotSwappable>;)
-
+template class std::variant<int, NotSwappable>;
+#endif
 
 int main() {
   test_swap_valueless_by_exception();



Index: test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp
===================================================================
--- test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp
+++ test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp
@@ -577,10 +577,10 @@
   }
 }
 
-
+#ifdef _LIBCPP_VERSION
 // This is why variant should SFINAE member swap. :-)
-LIBCPP_ONLY(template class std::variant<int, NotSwappable>;)
-
+template class std::variant<int, NotSwappable>;
+#endif
 
 int main() {
   test_swap_valueless_by_exception();

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits