bader wrote:

The change seems reasonable.

> CodeGen/LLVM will default to AS0 in this case, which produces Globals that 
> end up in the private address space for e.g. OCL, HIPSPV or SYCL.

Can we add a test checking LLVM address space for globals emitted from 
OCL/HIPSPV/SYCL, please? It's surprising that we need to modify only a 
datalayout string check.

https://github.com/llvm/llvm-project/pull/88455
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to