=?utf-8?q?Balázs_Kéri?= <balazs.k...@ericsson.com>, =?utf-8?q?Balázs_Kéri?= <balazs.k...@ericsson.com>, =?utf-8?q?Balázs_Kéri?= <balazs.k...@ericsson.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/89...@github.com>
https://github.com/NagyDonat approved this pull request. LGTM, the diff is clean and the results on open source projects are good enough for a non-alpha checker. Note that the direct codechecker links show the pedantic-only results which are... well, pedantic. Turning off the comparison and filtering for "alpha.unix.Stream" shows the default behavior of the checker, which is reasonable. On `vim` even non-pedantic mode produces dozens of reports, but that's because the code assumes that the input files are well-formed (no EOF in the middle of a record) -- and this checker should definitely report that kind of assumption. (If the developers don't want to see this kind of warning, they can disable this checker.) I think that this PR can be merged as it is now, but let's wait a week and see whether @haoNoQ or @Xazax-hun have any suggestions or objections. https://github.com/llvm/llvm-project/pull/89247 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
