dcoughlin accepted this revision. dcoughlin added a comment. Overall, this looks good to me. Thanks for tackling this!
One request, though. Could you move the tests into already existing test files? We're trying to avoid test files that only test a single issue. This makes it easier for people who are new to the project to determine where a new test should go. I think test1 could go in perhaps malloc.c and test2 could go in misc-ps.c. It would also be good to have both test functions mention the PR so a future maintainer can tell they are related even though they are in different files. https://reviews.llvm.org/D22862 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
