klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D27138#607859, @joerg wrote:
> Which struct are we talking about, `CompileCommandRef` or `CompileCommand`?
> It is a pointer in the former and a plain StringRef in the latter. I don't
> think making it a pointer in both is an advantage, i.e. distinguishing empty
> input from missing field is not valuable in my opinion.
Ok, you convinced me. LG then.
cfe-commits mailing list