jlebar added a comment.

> where would be the right place for me to put a test to check that it is 
> working (i.e. ASAN still works for CUDA host code).

I just ran the test from https://reviews.llvm.org/rL281680, and it passes 
because it doesn't notice clang raising the "unsupported option 
'-fsanitize=address" error.  :)

> I don't understand this part of the driver code very well

What I would probably do (other than ask Kostya, who may just Know) is first 
identify which commit caused the regression.  That will probably give us some 
idea of whether or not this is the right fix (and whether or not the check in 
https://reviews.llvm.org/rL281680 is still necessary).

Comment at: lib/Driver/SanitizerArgs.cpp:214
+      break;
+    }
     const auto *Arg = *I;
Nit, remove braces.


cfe-commits mailing list

Reply via email to