erichkeane wrote:

> > @Sirraide, would you add those (or similar if you feel that changes are 
> > needed) directly to that PR?
> 
> Yeah, that looks reasonable. If this works for clspv, then I’ll integrate 
> these changes into this pr.
> 
> That means I can remove the `omp_assume` spelling for `[[omp::assume]]` that 
> this pr was going to add as a temporary measure, because that’s not going to 
> be needed anymore.

Thats fantastic!

However, I'd suggest instead adding the clspv attribute in a separate 
review/commit.  It isn't really related to this one, other than this has a 
slight dependency on it.

https://github.com/llvm/llvm-project/pull/84934
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to