erikjv marked 7 inline comments as done.
erikjv added inline comments.

================
Comment at: lib/Serialization/ASTReader.cpp:2816
+        }
+        PP.setReplayablePreambleConditionalStack(ConditionalStack);
+      }
----------------
rsmith wrote:
> Why can't we set the conditional stack on the `PPLexer` directly from here? 
> (Why do we need to store it separately?)
Because there is no PPLexer yet. The deserialization is kicked off by 
ASTUnit::CodeComplete in Act->BeginSourceFile, while the lexer is created in 
Act->Execute.


https://reviews.llvm.org/D15994



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D15994: Allow for ... Erik Verbruggen via Phabricator via cfe-commits

Reply via email to