firolino marked 2 inline comments as done.
firolino added inline comments.
================
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:133
+ VariableLocation.setBegin(tidy::utils::lexer::findLocationAfterToken(
+ VariableLocation.getEnd(), Tokens, *Result.Context));
+ }
----------------
arphaman wrote:
> If you use `ArrayRef` in `findLocationAfterToken` then you won't need to
> create a `std::vector` here as you should be able to pass in a constant array
> `{tok::semi, tok::comma}`
This should even work with std::vector, since we have initializer_lists. I have
created Token because of [[
http://llvm.org/docs/CodingStandards.html#do-not-use-braced-initializer-lists-to-call-a-constructor
| Do not use Braced Initializer Lists to Call a Constructor ]] and readability
reasons.
Anyway, this function isn't included in the newest version :)
https://reviews.llvm.org/D27621
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
