Was this change approved by anyone? Generally once it's sent for review, you should wait until it's approved before committing (the assumption being, if you sent it for review it's because it needed review)
On Wed, Dec 14, 2016 at 12:49 PM Amjad Aboud via Phabricator via cfe-commits <cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL289701: [DebugInfo] Changed > DIBuilder::createCompileUnit() to take DIFile instead of… (authored by > aaboud). > > Changed prior to commit: > https://reviews.llvm.org/D27763?vs=81397&id=81438#toc > > Repository: > rL LLVM > > https://reviews.llvm.org/D27763 > > Files: > cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > > > Index: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > =================================================================== > --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > @@ -466,7 +466,8 @@ > // Create new compile unit. > // FIXME - Eliminate TheCU. > TheCU = DBuilder.createCompileUnit( > - LangTag, remapDIPath(MainFileName), > remapDIPath(getCurrentDirname()), > + LangTag, DBuilder.createFile(remapDIPath(MainFileName), > + remapDIPath(getCurrentDirname())), > Producer, LO.Optimize, CGM.getCodeGenOpts().DwarfDebugFlags, > RuntimeVers, > CGM.getCodeGenOpts().SplitDwarfFile, EmissionKind, 0 /* DWOid */, > CGM.getCodeGenOpts().SplitDwarfInlining); > @@ -1977,10 +1978,11 @@ > // but LLVM detects skeleton CUs by looking for a non-zero DWO id. > uint64_t Signature = Mod.getSignature() ? Mod.getSignature() : ~1ULL; > llvm::DIBuilder DIB(CGM.getModule()); > - DIB.createCompileUnit(TheCU->getSourceLanguage(), Mod.getModuleName(), > - Mod.getPath(), TheCU->getProducer(), true, > - StringRef(), 0, Mod.getASTFile(), > - llvm::DICompileUnit::FullDebug, Signature); > + DIB.createCompileUnit(TheCU->getSourceLanguage(), > + DIB.createFile(Mod.getModuleName(), > Mod.getPath()), > + TheCU->getProducer(), true, StringRef(), 0, > + Mod.getASTFile(), > llvm::DICompileUnit::FullDebug, > + Signature); > DIB.finalize(); > } > llvm::DIModule *Parent = > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
