malcolm.parsons added inline comments.
================
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:77-78
+static bool sameValue(const Expr *E1, const Expr *E2) {
+ E1 = ignoreUnaryPlus(getInitializer(E1->IgnoreImpCasts()));
+ E2 = ignoreUnaryPlus(getInitializer(E2->IgnoreImpCasts()));
+
----------------
aaron.ballman wrote:
> malcolm.parsons wrote:
> > aaron.ballman wrote:
> > > Do you also want to ignore paren expressions?
> > Maybe.
> > Am I reimplementing some existing clang function here?
> You can use `IgnoreParenImpCasts()` instead.
I mean is sameValue() implemented elsewhere?
https://reviews.llvm.org/D26750
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
