On 1/18/17 11:26 AM, Richard Smith via cfe-commits wrote:
On 18 January 2017 at 10:12, Jonathan Roelofs via cfe-commits
<cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote:

    Author: jroelofs
    Date: Wed Jan 18 12:12:39 2017
    New Revision: 292418

    URL: http://llvm.org/viewvc/llvm-project?rev=292418&view=rev
    <http://llvm.org/viewvc/llvm-project?rev=292418&view=rev>
    Log:
    Revert r286788

    The Itanium ABI [1] specifies that __cxa_demangle accept either:

       1) symbol names, which start with "_Z"
       2) type manglings, which do not start with "_Z"

    r286788 erroneously assumes that it should only handle symbols, so
    this patch
    reverts it and adds a counterexample to the testcase.

    1: https://mentorembedded.github.io/cxx-abi/abi.html#demangler
    <https://mentorembedded.github.io/cxx-abi/abi.html#demangler>


Thanks! Just FYI, the ABI document now lives
here: https://itanium-cxx-abi.github.io/cxx-abi/

Ah, didn't realize the canonical location changed. Should I get someone to change where this redirect points?

   "http://www.codesourcery.com/cxx-abi/: External link to this page"

As-is, that points at the 'mentorembedded.github.io' one.


Jon


    Reviewers: zygoloid, EricWF

    Modified:
        libcxxabi/trunk/src/cxa_demangle.cpp
        libcxxabi/trunk/test/test_demangle.pass.cpp



--
Jon Roelofs
jonat...@codesourcery.com
CodeSourcery / Mentor Embedded
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to