aaron.ballman added a comment.

In https://reviews.llvm.org/D28924#651139, @jordan_rose wrote:

> Interestingly, this case doesn't actually work yet; we unconditionally print 
> enum attributes after the close-brace even though that's not valid for C++ 
> attributes. Do you think I should change that as well, or just land this 
> patch as is?


This is a pervasive issue with attributes, now that I put my thinking cap on. I 
think you're fine to land it as-is; we need a much larger fix to handle pretty 
printing attributes properly for all flavors.


Repository:
  rL LLVM

https://reviews.llvm.org/D28924



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to