mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.

this LGTM.   assert is not something we should have in the dylib.



================
Comment at: include/__config:827
 #   endif
+# if !defined(_LIBCPP_BUILDING_LIBRARY)
 #   define _LIBCPP_EXTERN_TEMPLATE(...)
----------------
Does this belong here?



https://reviews.llvm.org/D29063



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to