https://github.com/erichkeane commented:

Implementation seems reasonable to me, a couple of nits (and please make more 
detailed asserts for everything!), though I haven't paid attention to these 
reviews in long enough someone else should take a look.

https://github.com/llvm/llvm-project/pull/112126
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to